|
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.CSharp;
using Test.Utilities;
using Xunit;
using VerifyCS = Test.Utilities.CSharpCodeFixVerifier<
Roslyn.Diagnostics.CSharp.Analyzers.CSharpAvoidOptSuffixForNullableEnableCode,
Roslyn.Diagnostics.CSharp.Analyzers.CSharpAvoidOptSuffixForNullableEnableCodeCodeFixProvider>;
namespace Roslyn.Diagnostics.Analyzers.UnitTests
{
public class CSharpAvoidOptSuffixForNullableEnableCodeTests
{
[Fact]
public Task RS0046_CSharp8_NullableEnabledCode_DiagnosticAsync()
=> new VerifyCS.Test
{
LanguageVersion = LanguageVersion.CSharp8,
TestCode = """
#nullable enable
public class Class1
{
private Class1? [|_instanceOpt|], [|otherInstanceOpt|];
public Class1? [|PropertyOpt|] { get; set; }
public void Method1(string? [|sOpt|])
{
string? [|localOpt|] = null, [|otherLocalOpt|] = null;
System.Console.WriteLine("{0}, {1}, {2}, {3}, {4}, {5}", _instanceOpt, otherInstanceOpt, PropertyOpt, sOpt, localOpt, otherLocalOpt);
}
}
""",
FixedCode = """
#nullable enable
public class Class1
{
private Class1? _instance, otherInstance;
public Class1? Property { get; set; }
public void Method1(string? s)
{
string? local = null, otherLocal = null;
System.Console.WriteLine("{0}, {1}, {2}, {3}, {4}, {5}", _instance, otherInstance, Property, s, local, otherLocal);
}
}
""",
}.RunAsync();
[Fact]
public Task RS0046_CSharp8_NullableEnabledCodeNonNullableType_NoDiagnosticAsync()
=> new VerifyCS.Test
{
LanguageVersion = LanguageVersion.CSharp8,
TestCode = """
#nullable enable
public class Class1
{
private Class1 _instanceOpt = new Class1(), otherInstanceOpt = new Class1();
public Class1 PropertyOpt { get; set; } = new Class1();
public void Method1(string sOpt)
{
string localOpt, otherLocalOpt;
}
}
""",
}.RunAsync();
[Fact]
public Task RS0046_CSharp8_NullableEnabledCodeValueType_DiagnosticAsync()
=> new VerifyCS.Test
{
LanguageVersion = LanguageVersion.CSharp8,
TestCode = """
#nullable enable
public enum MyEnum { A, }
public class Class1
{
private MyEnum? [|_instanceOpt|], [|otherInstanceOpt|];
public MyEnum? [|PropertyOpt|] { get; set; }
public void Method1(MyEnum? [|eOpt|])
{
MyEnum? [|localOpt|] = null, [|otherLocalOpt|] = null;
System.Console.WriteLine("{0}, {1}, {2}, {3}, {4}, {5}", _instanceOpt, otherInstanceOpt, PropertyOpt, eOpt, localOpt, otherLocalOpt);
}
}
""",
FixedCode = """
#nullable enable
public enum MyEnum { A, }
public class Class1
{
private MyEnum? _instance, otherInstance;
public MyEnum? Property { get; set; }
public void Method1(MyEnum? e)
{
MyEnum? local = null, otherLocal = null;
System.Console.WriteLine("{0}, {1}, {2}, {3}, {4}, {5}", _instance, otherInstance, Property, e, local, otherLocal);
}
}
""",
}.RunAsync();
[Fact]
public Task RS0046_CSharp8_NullableEnabledCodeNonNullableValueType_NoDiagnosticAsync()
=> new VerifyCS.Test
{
LanguageVersion = LanguageVersion.CSharp8,
TestCode = """
#nullable enable
public enum MyEnum { A, }
public class Class1
{
private MyEnum _instanceOpt = MyEnum.A, otherInstanceOpt = MyEnum.A;
public MyEnum PropertyOpt { get; set; }
public void Method1(MyEnum eOpt)
{
MyEnum localOpt, otherLocalOpt;
}
}
""",
}.RunAsync();
[Fact]
public Task RS0046_CSharp8_NonNullableEnabledCode_NoDiagnosticAsync()
=> new VerifyCS.Test
{
LanguageVersion = LanguageVersion.CSharp8,
TestCode =
"""
public class Class1
{
private Class1 _instanceOpt, otherInstanceOpt;
public Class1 PropertyOpt { get; set; }
public void Method1(string sOpt)
{
string localOpt, otherLocalOpt;
}
}
""",
}.RunAsync();
[Fact]
public Task RS0046_CSharp8_NullableDisabledCode_NoDiagnosticAsync()
=> new VerifyCS.Test
{
LanguageVersion = LanguageVersion.CSharp8,
TestCode =
"""
#nullable disable
public class Class1
{
private Class1 _instanceOpt, otherInstanceOpt;
public Class1 PropertyOpt { get; set; }
public void Method1(string sOpt)
{
string localOpt, otherLocalOpt;
}
}
""",
}.RunAsync();
[Fact]
public Task RS0046_PriorToCSharp8_NoDiagnosticAsync()
=> new VerifyCS.Test
{
LanguageVersion = LanguageVersion.CSharp7_3,
TestCode =
"""
public class Class1
{
private Class1 _instanceOpt, otherInstanceOpt;
public Class1 PropertyOpt { get; set; }
public void Method1(string sOpt)
{
string localOpt, otherLocalOpt;
}
}
""",
}.RunAsync();
[Fact(Skip = "https://github.com/dotnet/roslyn-analyzers/issues/3707")]
public Task RS0046_CSharp8_VariableWithoutOptAlreadyExists_DiagnosticButNoCodeFixAsync()
=> new VerifyCS.Test
{
LanguageVersion = LanguageVersion.CSharp8,
TestCode = """
#nullable enable
public class Class1
{
private Class1? [|_instanceOpt|], _instance;
public Class1? [|PropertyOpt|] { get; set; }
public Class1? Property { get; set; }
public void Method1(string? [|sOpt|], string? s)
{
string? [|localOpt|], local;
}
}
""",
FixedCode = """
#nullable enable
public class Class1
{
private Class1? [|_instanceOpt|], _instance;
public Class1? [|PropertyOpt|] { get; set; }
public Class1? Property { get; set; }
public void Method1(string? [|sOpt|], string? s)
{
string? [|localOpt|], local;
}
}
""",
}.RunAsync();
[Fact]
public Task RS0046_CSharp8_UnknownType_DiagnosticAndCodeFixAsync()
=> new VerifyCS.Test
{
LanguageVersion = LanguageVersion.CSharp8,
TestCode = """
#nullable enable
public class Class1
{
private {|CS0246:Class2|}? [|_instanceOpt|];
public {|CS0246:Class2|}? [|PropertyOpt|] { get; set; }
public void Method1({|CS0246:Class2|}? [|sOpt|])
{
{|CS0246:Class2|}? [|localOpt|];
}
}
""",
FixedCode = """
#nullable enable
public class Class1
{
private {|CS0246:Class2|}? _instance;
public {|CS0246:Class2|}? Property { get; set; }
public void Method1({|CS0246:Class2|}? s)
{
{|CS0246:Class2|}? local;
}
}
""",
}.RunAsync();
[Fact, WorkItem(3813, "https://github.com/dotnet/roslyn-analyzers/issues/3813")]
public Task RS0046_CSharp8_NullableEnabledCode_InterfaceImplementation_NoDiagnosticAsync()
=> new VerifyCS.Test
{
LanguageVersion = LanguageVersion.CSharp8,
TestCode = """
#nullable enable
public interface ISomething
{
ISomething? [|PropertyOpt|] { get; set; }
void Method1(string? [|sOpt|]);
}
public class Class1 : ISomething
{
public ISomething? PropertyOpt { get; set; }
public void Method1(string? sOpt)
{
string? [|localOpt|] = null, [|otherLocalOpt|] = null;
System.Console.WriteLine("{0}, {1}, {2}, {3}", PropertyOpt, sOpt, localOpt, otherLocalOpt);
}
}
""",
FixedCode = """
#nullable enable
public interface ISomething
{
ISomething? Property { get; set; }
void Method1(string? s);
}
public class Class1 : ISomething
{
public ISomething? Property { get; set; }
public void Method1(string? sOpt)
{
string? local = null, otherLocal = null;
System.Console.WriteLine("{0}, {1}, {2}, {3}", Property, sOpt, local, otherLocal);
}
}
""",
}.RunAsync();
[Fact, WorkItem(3813, "https://github.com/dotnet/roslyn-analyzers/issues/3813")]
public Task RS0046_CSharp8_NullableEnabledCode_Override_NoDiagnosticAsync()
=> new VerifyCS.Test
{
LanguageVersion = LanguageVersion.CSharp8,
TestCode = """
#nullable enable
public class Base
{
public virtual Base? [|PropertyOpt|] { get; set; }
public virtual void Method1(string? [|sOpt|])
{
System.Console.WriteLine("{0}", sOpt);
}
}
public class Derived : Base
{
public override Base? PropertyOpt { get; set; }
public override void Method1(string? sOpt)
{
string? [|localOpt|] = null, [|otherLocalOpt|] = null;
System.Console.WriteLine("{0}, {1}, {2}, {3}", PropertyOpt, sOpt, localOpt, otherLocalOpt);
}
}
""",
FixedCode = """
#nullable enable
public class Base
{
public virtual Base? Property { get; set; }
public virtual void Method1(string? s)
{
System.Console.WriteLine("{0}", s);
}
}
public class Derived : Base
{
public override Base? Property { get; set; }
public override void Method1(string? sOpt)
{
string? local = null, otherLocal = null;
System.Console.WriteLine("{0}, {1}, {2}, {3}", Property, sOpt, local, otherLocal);
}
}
""",
}.RunAsync();
}
}
|