File: GivenThatWeWantToPackAToolProjectWithPackagedShim.cs
Web Access
Project: ..\..\..\test\Microsoft.NET.ToolPack.Tests\Microsoft.NET.ToolPack.Tests.csproj (Microsoft.NET.ToolPack.Tests)
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
 
#nullable disable
 
using System.Runtime.CompilerServices;
using NuGet.Frameworks;
using NuGet.Packaging;
 
namespace Microsoft.NET.ToolPack.Tests
{
    public class GivenThatWeWantToPackAToolProjectWithPackagedShim : SdkTest, IClassFixture<NupkgOfPackWithShimsFixture>
    {
        private string _testRoot;
        private string _packageId;
        private string _packageVersion = "1.0.0";
        private const string _customToolCommandName = "customToolCommandName";
        readonly NupkgOfPackWithShimsFixture _fixture;
 
        public GivenThatWeWantToPackAToolProjectWithPackagedShim(NupkgOfPackWithShimsFixture fixture, ITestOutputHelper log) : base(log)
        {
            fixture.Init(log, _testAssetsManager);
            _fixture = fixture;
        }
 
        private string SetupNuGetPackage(
            bool multiTarget,
            [CallerMemberName] string callingMethod = "",
            Dictionary<string, string> additionalProperty = null,
            string targetFramework = null)
        {
            TestAsset helloWorldAsset = CreateTestAsset(
                multiTarget,
                callingMethod + multiTarget + targetFramework,
                targetFramework,
                additionalProperty);
 
            _testRoot = helloWorldAsset.TestRoot;
 
            var packCommand = new PackCommand(helloWorldAsset);
            packCommand.Execute().Should().Pass();
            _packageId = Path.GetFileNameWithoutExtension(packCommand.ProjectFile);
 
            return packCommand.GetNuGetPackage(packageVersion: _packageVersion);
        }
 
        private TestAsset CreateTestAsset(
            bool multiTarget,
            string assetName,
            string targetFramework,
            Dictionary<string, string> additionalProperty = null)
        {
            return _testAssetsManager
                .CopyTestAsset("PortableTool", assetName)
                .WithSource()
                .WithProjectChanges(project =>
                {
                    XNamespace ns = project.Root.Name.Namespace;
                    XElement propertyGroup = project.Root.Elements(ns + "PropertyGroup").First();
                    propertyGroup.Add(new XElement(ns + "PackAsToolShimRuntimeIdentifiers", $"win-x64;{ToolsetInfo.LatestMacRuntimeIdentifier}-x64"));
                    propertyGroup.Add(new XElement(ns + "ToolCommandName", _customToolCommandName));
 
                    if (additionalProperty != null)
                    {
                        foreach (KeyValuePair<string, string> pair in additionalProperty)
                        {
                            propertyGroup.Add(new XElement(ns + pair.Key, pair.Value));
                        }
                    }
                })
                .WithTargetFrameworkOrFrameworks(targetFramework, multiTarget);
        }
 
        [Theory]
        [InlineData(true, "netcoreapp2.1")]
        [InlineData(false, "netcoreapp2.1")]
        [InlineData(true, ToolsetInfo.CurrentTargetFramework)]
        [InlineData(false, ToolsetInfo.CurrentTargetFramework)]
        public void It_packs_successfully(bool multiTarget, string targetFramework)
        {
            var nugetPackage = _fixture.GetTestToolPackagePath(multiTarget, targetFramework: targetFramework);
            using (var nupkgReader = new PackageArchiveReader(nugetPackage))
            {
                nupkgReader
                    .GetToolItems()
                    .Should().NotBeEmpty();
            }
        }
 
        [Theory]
        [InlineData(true, "netcoreapp2.1")]
        [InlineData(false, "netcoreapp2.1")]
        [InlineData(true, ToolsetInfo.CurrentTargetFramework)]
        [InlineData(false, ToolsetInfo.CurrentTargetFramework)]
        public void It_contains_dependencies_dll(bool multiTarget, string targetFramework)
        {
            var nugetPackage = _fixture.GetTestToolPackagePath(multiTarget, targetFramework: targetFramework);
            using (var nupkgReader = new PackageArchiveReader(nugetPackage))
            {
                IEnumerable<NuGetFramework> supportedFrameworks = nupkgReader.GetSupportedFrameworks();
                supportedFrameworks.Should().NotBeEmpty();
 
                foreach (NuGetFramework framework in supportedFrameworks)
                {
                    var allItems = nupkgReader.GetToolItems().SelectMany(i => i.Items).ToList();
                    allItems.Should().Contain($"tools/{framework.GetShortFolderName()}/any/Newtonsoft.Json.dll");
                }
            }
        }
 
        [Theory]
        [InlineData(true, "netcoreapp2.1")]
        [InlineData(false, "netcoreapp2.1")]
        [InlineData(true, ToolsetInfo.CurrentTargetFramework)]
        [InlineData(false, ToolsetInfo.CurrentTargetFramework)]
        public void It_contains_shim(bool multiTarget, string targetFramework)
        {
            var nugetPackage = _fixture.GetTestToolPackagePath(multiTarget, targetFramework: targetFramework);
            using (var nupkgReader = new PackageArchiveReader(nugetPackage))
            {
                IEnumerable<NuGetFramework> supportedFrameworks = nupkgReader.GetSupportedFrameworks();
                supportedFrameworks.Should().NotBeEmpty();
 
                foreach (NuGetFramework framework in supportedFrameworks)
                {
                    var allItems = nupkgReader.GetToolItems().SelectMany(i => i.Items).ToList();
                    allItems.Should().Contain($"tools/{framework.GetShortFolderName()}/any/shims/win-x64/{NupkgOfPackWithShimsFixture._customToolCommandName}.exe",
                        "Name should be the same as the command name even customized");
                    allItems.Should().Contain($"tools/{framework.GetShortFolderName()}/any/shims/{ToolsetInfo.LatestMacRuntimeIdentifier}-x64/{NupkgOfPackWithShimsFixture._customToolCommandName}",
                        "RID should be the exact match of the RID in the property, even Apphost only has version of win, osx and linux");
                }
            }
        }
 
        [Theory]
        [InlineData(true, "netcoreapp2.1")]
        [InlineData(false, "netcoreapp2.1")]
        [InlineData(true, ToolsetInfo.CurrentTargetFramework)]
        [InlineData(false, ToolsetInfo.CurrentTargetFramework)]
        public void It_uses_customized_PackagedShimOutputRootDirectory(bool multiTarget, string targetFramework)
        {
            string shimoutputPath = Path.Combine(TestContext.Current.TestExecutionDirectory, "shimoutput");
            TestAsset helloWorldAsset = _testAssetsManager
                .CopyTestAsset("PortableTool", "PackagedShimOutputRootDirectory" + multiTarget.ToString(), identifier: multiTarget.ToString() + targetFramework)
                .WithSource()
                .WithProjectChanges(project =>
                {
                    XNamespace ns = project.Root.Name.Namespace;
                    XElement propertyGroup = project.Root.Elements(ns + "PropertyGroup").First();
                    propertyGroup.Add(new XElement(ns + "PackAsToolShimRuntimeIdentifiers", $"win-x64;{ToolsetInfo.LatestMacRuntimeIdentifier}-x64"));
                    propertyGroup.Add(new XElement(ns + "ToolCommandName", _customToolCommandName));
                    propertyGroup.Add(new XElement(ns + "PackagedShimOutputRootDirectory", shimoutputPath));
                })
                .WithTargetFrameworkOrFrameworks(targetFramework, multiTarget);
 
            _testRoot = helloWorldAsset.TestRoot;
 
            new PackCommand(Log, helloWorldAsset.TestRoot).Execute().Should().Pass();
 
            string windowShimPath = Path.Combine(shimoutputPath, $"shims/{targetFramework}/win-x64/{_customToolCommandName}.exe");
            File.Exists(windowShimPath).Should().BeTrue($"Shim {windowShimPath} should exist");
            string osxShimPath = Path.Combine(shimoutputPath, $"shims/{targetFramework}/{ToolsetInfo.LatestMacRuntimeIdentifier}-x64/{_customToolCommandName}");
            File.Exists(osxShimPath).Should().BeTrue($"Shim {osxShimPath} should exist");
        }
 
        [Theory]
        [InlineData(true, "netcoreapp2.1")]
        [InlineData(false, "netcoreapp2.1")]
        [InlineData(true, ToolsetInfo.CurrentTargetFramework)]
        [InlineData(false, ToolsetInfo.CurrentTargetFramework)]
        public void It_uses_outputs_to_bin_by_default(bool multiTarget, string targetFramework)
        {
            TestAsset helloWorldAsset = CreateTestAsset(
                multiTarget,
                nameof(It_uses_outputs_to_bin_by_default)
                + multiTarget
                + targetFramework,
                targetFramework: targetFramework);
 
            _testRoot = helloWorldAsset.TestRoot;
 
            var packCommand = new PackCommand(helloWorldAsset);
            var outputDirectory = packCommand.GetOutputDirectory(targetFramework);
            packCommand.Execute().Should().Pass();
 
            string windowShimPath = Path.Combine(outputDirectory.FullName, $"shims/{targetFramework}/win-x64/{_customToolCommandName}.exe");
            File.Exists(windowShimPath).Should().BeTrue($"Shim {windowShimPath} should exist");
            string osxShimPath = Path.Combine(outputDirectory.FullName, $"shims/{targetFramework}/{ToolsetInfo.LatestMacRuntimeIdentifier}-x64/{_customToolCommandName}");
            File.Exists(osxShimPath).Should().BeTrue($"Shim {osxShimPath} should exist");
        }
 
        [Theory]
        [InlineData(true, "netcoreapp2.1")]
        [InlineData(false, "netcoreapp2.1")]
        [InlineData(true, ToolsetInfo.CurrentTargetFramework)]
        [InlineData(false, ToolsetInfo.CurrentTargetFramework)]
        public void Clean_should_remove_bin_output(bool multiTarget, string targetFramework)
        {
            TestAsset helloWorldAsset = CreateTestAsset(
                multiTarget,
                nameof(Clean_should_remove_bin_output)
                + multiTarget
                + targetFramework,
                targetFramework: targetFramework);
 
            _testRoot = helloWorldAsset.TestRoot;
 
            var packCommand = new PackCommand(Log, helloWorldAsset.TestRoot);
            packCommand.Execute().Should().Pass();
 
            var cleanCommand = new CleanCommand(Log, helloWorldAsset.TestRoot);
            cleanCommand.Execute().Should().Pass();
 
            var outputDirectory = packCommand.GetOutputDirectory("netcoreapp2.1");
            string windowShimPath = Path.Combine(outputDirectory.FullName, $"shims/netcoreapp2.1/win-x64/{_customToolCommandName}.exe");
            File.Exists(windowShimPath).Should().BeFalse($"Shim {windowShimPath} should not exists");
            string osxShimPath = Path.Combine(outputDirectory.FullName, $"shims/netcoreapp2.1/{ToolsetInfo.LatestMacRuntimeIdentifier}-x64/{_customToolCommandName}");
            File.Exists(osxShimPath).Should().BeFalse($"Shim {osxShimPath} should not exists");
        }
 
        [Theory]
        [InlineData(true, "netcoreapp2.1")]
        [InlineData(false, "netcoreapp2.1")]
        [InlineData(true, ToolsetInfo.CurrentTargetFramework)]
        [InlineData(false, ToolsetInfo.CurrentTargetFramework)]
        public void Generate_shims_runs_incrementally(bool multiTarget, string targetFramework)
        {
            TestAsset helloWorldAsset = CreateTestAsset(
                multiTarget,
                nameof(Generate_shims_runs_incrementally)
                + multiTarget
                + targetFramework,
                targetFramework: targetFramework);
 
            _testRoot = helloWorldAsset.TestRoot;
 
            var buildCommand = new BuildCommand(helloWorldAsset);
            buildCommand.Execute().Should().Pass();
 
            var outputDirectory = buildCommand.GetOutputDirectory(targetFramework);
            string windowShimPath = Path.Combine(outputDirectory.FullName, $"shims/{targetFramework}.1/win-x64/{_customToolCommandName}.exe");
 
            DateTime windowShimPathFirstModifiedTime = File.GetLastWriteTimeUtc(windowShimPath);
 
            buildCommand.Execute().Should().Pass();
 
            DateTime windowShimPathSecondModifiedTime = File.GetLastWriteTimeUtc(windowShimPath);
 
            windowShimPathSecondModifiedTime.Should().Be(windowShimPathFirstModifiedTime);
        }
 
        [Theory]
        [InlineData(true, "netcoreapp2.1")]
        [InlineData(false, "netcoreapp2.1")]
        [InlineData(true, ToolsetInfo.CurrentTargetFramework)]
        [InlineData(false, ToolsetInfo.CurrentTargetFramework)]
        public void It_contains_shim_with_no_build(bool multiTarget, string targetFramework)
        {
            var testAsset = CreateTestAsset(multiTarget, nameof(It_contains_shim_with_no_build) + multiTarget + targetFramework, targetFramework);
 
            var buildCommand = new BuildCommand(testAsset).WithWorkingDirectory(testAsset.Path);
            buildCommand.Execute().Should().Pass();
 
            var packCommand = new PackCommand(testAsset).WithWorkingDirectory(testAsset.Path) as PackCommand;
            var binlogDestPath = Environment.GetEnvironmentVariable("HELIX_WORKITEM_UPLOAD_ROOT") is { } ciOutputRoot ?
                Path.Combine(ciOutputRoot, "binlog", $"{nameof(It_contains_shim_with_no_build)}_{multiTarget}_{targetFramework}.binlog") :
                "./msbuild.binlog";
 
            packCommand.Execute($"/p:NoBuild=true", $"/bl:{binlogDestPath}").Should().Pass();
            var nugetPackage = packCommand.GetNuGetPackage();
 
            using (var nupkgReader = new PackageArchiveReader(nugetPackage))
            {
                IEnumerable<NuGetFramework> supportedFrameworks = nupkgReader.GetSupportedFrameworks();
                supportedFrameworks.Should().NotBeEmpty();
 
                foreach (NuGetFramework framework in supportedFrameworks)
                {
                    var allItems = nupkgReader.GetToolItems().SelectMany(i => i.Items).ToList();
                    allItems.Should().Contain($"tools/{framework.GetShortFolderName()}/any/shims/win-x64/{_customToolCommandName}.exe",
                        "Name should be the same as the command name even customized");
                    allItems.Should().Contain($"tools/{framework.GetShortFolderName()}/any/shims/{ToolsetInfo.LatestMacRuntimeIdentifier}-x64/{_customToolCommandName}",
                        "RID should be the exact match of the RID in the property, even Apphost only has version of win, osx and linux");
                }
            }
        }
 
        [WindowsOnlyTheory]
        [InlineData(true, ToolsetInfo.CurrentTargetFramework)]
        [InlineData(false, ToolsetInfo.CurrentTargetFramework)]
        public void It_produces_valid_shims(bool multiTarget, string targetFramework)
        {
            if (!Environment.Is64BitOperatingSystem)
            {
                // only sample test on win-x64 since shims are RID specific
                return;
            }
 
            var nugetPackage = SetupNuGetPackage(multiTarget, targetFramework: targetFramework);
            AssertValidShim(_testRoot, nugetPackage);
        }
 
        [WindowsOnlyTheory]
        [InlineData(true, ToolsetInfo.CurrentTargetFramework)]
        [InlineData(false, ToolsetInfo.CurrentTargetFramework)]
        public void It_produces_valid_shims_when_the_first_build_is_wrong(bool multiTarget, string targetFramework)
        {
            // The first build use wrong package id and should embed wrong string to shims. However, the pack should produce correct shim
            // since it includes build target. And the incremental build should consider the shim to be invalid and recreate that.
 
            if (!Environment.Is64BitOperatingSystem)
            {
                // only sample test on win-x64 since shims are RID specific
                return;
            }
 
            TestAsset helloWorldAsset = CreateTestAsset(multiTarget,
                "It_produces_valid_shims2" + multiTarget + targetFramework,
                targetFramework: targetFramework);
 
            var testRoot = helloWorldAsset.TestRoot;
 
            var buildCommand = new BuildCommand(helloWorldAsset);
            buildCommand.Execute("/p:PackageId=wrongpackagefirstbuild");
 
            var packCommand = new PackCommand(helloWorldAsset);
 
            packCommand.Execute().Should().Pass();
            var nugetPackage = packCommand.GetNuGetPackage();
 
            _packageId = Path.GetFileNameWithoutExtension(packCommand.ProjectFile);
 
            AssertValidShim(testRoot, nugetPackage);
        }
 
        [WindowsOnlyTheory]
        [InlineData(true, ToolsetInfo.CurrentTargetFramework)]
        [InlineData(false, ToolsetInfo.CurrentTargetFramework)]
        public void When_version_and_packageVersion_is_different_It_produces_valid_shims(bool multiTarget, string targetFramework)
        {
            if (!Environment.Is64BitOperatingSystem)
            {
                // only sample test on win-x64 since shims are RID specific
                return;
            }
 
            var nugetPackage = SetupNuGetPackage(multiTarget,
                additionalProperty: new Dictionary<string, string>()
                {
                    ["version"] = "1.0.0-rtm",
                    ["packageVersion"] = _packageVersion
                },
                targetFramework: targetFramework);
 
            AssertValidShim(_testRoot, nugetPackage);
        }
 
        [WindowsOnlyTheory]
        [InlineData(true, ToolsetInfo.CurrentTargetFramework)]
        [InlineData(false, ToolsetInfo.CurrentTargetFramework)]
        public void When_version_and_packageVersion_is_different_It_produces_valid_shims2(bool multiTarget, string targetFramework)
        {
            if (!Environment.Is64BitOperatingSystem)
            {
                // only sample test on win-x64 since shims are RID specific
                return;
            }
 
            _packageVersion = "1000.0.0";
 
            var nugetPackage = SetupNuGetPackage(multiTarget,
                additionalProperty: new Dictionary<string, string>()
                {
                    ["version"] = "1000",
                },
                targetFramework: targetFramework);
 
            AssertValidShim(_testRoot, nugetPackage);
        }
 
        [Fact]
        public void Given_wpf_project_It_contains_shim_with_WindowsGraphicalUserInterfaceBit()
        {
            ushort windowsGUISubsystem = 0x2;
            var testProject = new TestProject()
            {
                Name = "wpfTool",
                TargetFrameworks = "netcoreapp3.0",
                ProjectSdk = "Microsoft.NET.Sdk.WindowsDesktop",
                IsWinExe = true,
            };
 
            testProject.AdditionalProperties.Add("EnableWindowsTargeting", "true");
            testProject.AdditionalProperties.Add("UseWPF", "true");
            testProject.AdditionalProperties.Add("PackAsToolShimRuntimeIdentifiers", $"win-x64;{ToolsetInfo.LatestMacRuntimeIdentifier}-x64");
            testProject.AdditionalProperties.Add("ToolCommandName", _customToolCommandName);
            testProject.AdditionalProperties.Add("PackAsTool", "true");
 
            TestAsset asset = _testAssetsManager.CreateTestProject(testProject);
            var packCommand = new PackCommand(Log, Path.Combine(asset.Path, testProject.Name));
 
            packCommand
                .Execute()
                .Should()
                .Pass();
 
            var nugetPackage = packCommand.GetNuGetPackage(packageVersion: _packageVersion);
 
            using (var nupkgReader = new PackageArchiveReader(nugetPackage))
            {
                IEnumerable<NuGetFramework> supportedFrameworks = nupkgReader.GetSupportedFrameworks();
                supportedFrameworks.Should().NotBeEmpty();
 
                var tmpfilePath = Path.Combine(asset.TestRoot, "temp", Path.GetRandomFileName());
                string copiedFile = nupkgReader.ExtractFile(
                    $"tools/netcoreapp3.0/any/shims/win-x64/{_customToolCommandName}.exe",
                    tmpfilePath,
                    null);
                HostModel.AppHost.PEUtils.GetWindowsGraphicalUserInterfaceBit(copiedFile).Should().Be(windowsGUISubsystem);
            }
        }
 
        private void AssertValidShim(string testRoot, string nugetPackage)
        {
            using (var nupkgReader = new PackageArchiveReader(nugetPackage))
            {
                IEnumerable<NuGetFramework> supportedFrameworks = nupkgReader.GetSupportedFrameworks();
                supportedFrameworks.Should().NotBeEmpty();
                var simulateToolPathRoot = Path.Combine(testRoot, "temp", Path.GetRandomFileName());
 
                foreach (NuGetFramework framework in supportedFrameworks)
                {
                    string[] portableAppContent = {
                        "consoledemo.runtimeconfig.json",
                        "consoledemo.deps.json",
                        "consoledemo.dll",
                        "Newtonsoft.Json.dll"};
                    CopyPackageAssetToToolLayout(portableAppContent, nupkgReader, simulateToolPathRoot, framework);
 
                    string shimPath = Path.Combine(simulateToolPathRoot, $"{_customToolCommandName}.exe");
                    nupkgReader.ExtractFile(
                        $"tools/{framework.GetShortFolderName()}/any/shims/win-x64/{_customToolCommandName}.exe",
                        shimPath,
                        null);
 
                    var command = new RunExeCommand(Log, shimPath)
                    {
                        WorkingDirectory = simulateToolPathRoot
                    };
                    command.Execute().Should()
                      .Pass()
                      .And
                      .HaveStdOutContaining("Hello World from Global Tool");
                }
            }
        }
 
        private void CopyPackageAssetToToolLayout(
            string[] nupkgAssetNames,
            PackageArchiveReader nupkgReader,
            string tmpfilePathRoot,
            NuGetFramework framework)
        {
            var toolLayoutDirectory =
                Path.Combine(
                    tmpfilePathRoot,
                    ".store",
                    _packageId,
                    _packageVersion,
                    _packageId,
                    _packageVersion,
                    "tools",
                    framework.GetShortFolderName(),
                    "any");
 
            foreach (string nupkgAssetName in nupkgAssetNames)
            {
                var destinationFilePath =
                    Path.Combine(toolLayoutDirectory, nupkgAssetName);
                nupkgReader.ExtractFile(
                    $"tools/{framework.GetShortFolderName()}/any/{nupkgAssetName}",
                    destinationFilePath,
                    null);
            }
        }
    }
}