|
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using System.Collections.Generic;
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.CodeFixes;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.CSharp.Analyzers.MakeFieldReadonly;
using Microsoft.CodeAnalysis.CSharp.MakeFieldReadonly;
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Diagnostics;
using Microsoft.CodeAnalysis.Test.Utilities;
using Roslyn.Test.Utilities;
using Roslyn.Utilities;
using Xunit;
using Xunit.Abstractions;
namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.MakeFieldReadonly;
[Trait(Traits.Feature, Traits.Features.CodeActionsMakeFieldReadonly)]
public class MakeFieldReadonlyTests : AbstractCSharpDiagnosticProviderBasedUserDiagnosticTest_NoEditor
{
private static readonly ParseOptions s_strictFeatureFlag = CSharpParseOptions.Default.WithFeatures([KeyValuePairUtil.Create("strict", "true")]);
public MakeFieldReadonlyTests(ITestOutputHelper logger)
: base(logger)
{
}
internal override (DiagnosticAnalyzer, CodeFixProvider) CreateDiagnosticProviderAndFixer(Workspace workspace)
=> (new CSharpMakeFieldReadonlyDiagnosticAnalyzer(), new CSharpMakeFieldReadonlyCodeFixProvider());
[Theory]
[InlineData("public")]
[InlineData("internal")]
[InlineData("protected")]
[InlineData("protected internal")]
[InlineData("private protected")]
public async Task NonPrivateField(string accessibility)
{
await TestMissingInRegularAndScriptAsync(
$@"class MyClass
{{
{accessibility} int[| _goo |];
}}");
}
[Fact]
public async Task FieldIsEvent()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private event System.EventHandler [|Goo|];
}
""");
}
[Fact]
public async Task FieldIsReadonly()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private readonly int [|_goo|];
}
""");
}
[Fact]
public async Task FieldIsConst()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private const int [|_goo|];
}
""");
}
[Fact]
public async Task FieldNotAssigned()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
}
""",
"""
class MyClass
{
private readonly int _goo;
}
""");
}
[Fact]
public async Task FieldNotAssigned_Struct()
{
await TestInRegularAndScript1Async(
"""
struct MyStruct
{
private int [|_goo|];
}
""",
"""
struct MyStruct
{
private readonly int _goo;
}
""");
}
[Fact]
public async Task FieldAssignedInline()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|] = 0;
}
""",
"""
class MyClass
{
private readonly int _goo = 0;
}
""");
}
[Fact]
public async Task MultipleFieldsAssignedInline_AllCanBeReadonly()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|] = 0, _bar = 0;
}
""",
"""
class MyClass
{
private readonly int _goo = 0;
private int _bar = 0;
}
""");
}
[Fact]
public async Task ThreeFieldsAssignedInline_AllCanBeReadonly_SeparatesAllAndKeepsThemInOrder()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int _goo = 0, [|_bar|] = 0, _fizz = 0;
}
""",
"""
class MyClass
{
private int _goo = 0;
private readonly int _bar = 0;
private int _fizz = 0;
}
""");
}
[Fact]
public async Task MultipleFieldsAssignedInline_OneIsAssignedInMethod()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int _goo = 0, [|_bar|] = 0;
Goo()
{
_goo = 0;
}
}
""",
"""
class MyClass
{
private int _goo = 0;
private readonly int _bar = 0;
Goo()
{
_goo = 0;
}
}
""");
}
[Fact]
public async Task MultipleFieldsAssignedInline_NoInitializer()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|], _bar = 0;
}
""",
"""
class MyClass
{
private readonly int _goo;
private int _bar = 0;
}
""");
}
[Theory]
[InlineData("")]
[InlineData("\r\n")]
[InlineData("\r\n\r\n")]
public async Task MultipleFieldsAssignedInline_LeadingCommentAndWhitespace(string leadingTrvia)
{
await TestInRegularAndScript1Async(
$@"class MyClass
{{
//Comment{leadingTrvia}
private int _goo = 0, [|_bar|] = 0;
}}",
$@"class MyClass
{{
//Comment{leadingTrvia}
private int _goo = 0;
private readonly int _bar = 0;
}}");
}
[Fact]
public async Task FieldAssignedInCtor()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
MyClass()
{
_goo = 0;
}
}
""",
"""
class MyClass
{
private readonly int _goo;
MyClass()
{
_goo = 0;
}
}
""");
}
[Fact]
public async Task FieldAssignedInSimpleLambdaInCtor()
{
await TestMissingInRegularAndScriptAsync(
"""
public class MyClass
{
private int [|_goo|];
public MyClass()
{
this.E = x => this._goo = 0;
}
public Action<int> E;
}
""");
}
[Fact]
public async Task FieldAssignedInLambdaInCtor()
{
await TestMissingInRegularAndScriptAsync(
"""
public class MyClass
{
private int [|_goo|];
public MyClass()
{
this.E += (_, __) => this._goo = 0;
}
public event EventHandler E;
}
""");
}
[Fact]
public async Task FieldAssignedInLambdaWithBlockInCtor()
{
await TestMissingInRegularAndScriptAsync(
"""
public class MyClass
{
private int [|_goo|];
public MyClass()
{
this.E += (_, __) => { this._goo = 0; }
}
public event EventHandler E;
}
""");
}
[Fact]
public async Task FieldAssignedInAnonymousFunctionInCtor()
{
await TestMissingInRegularAndScriptAsync(
"""
public class MyClass
{
private int [|_goo|];
public MyClass()
{
this.E = delegate { this._goo = 0; };
}
public Action<int> E;
}
""");
}
[Fact]
public async Task FieldAssignedInLocalFunctionExpressionBodyInCtor()
{
await TestMissingInRegularAndScriptAsync(
"""
public class MyClass
{
private int [|_goo|];
public MyClass()
{
void LocalFunction() => this._goo = 0;
}
}
""");
}
[Fact]
public async Task FieldAssignedInLocalFunctionBlockBodyInCtor()
{
await TestMissingInRegularAndScriptAsync(
"""
public class MyClass
{
private int [|_goo|];
public MyClass()
{
void LocalFunction() { this._goo = 0; }
}
}
""");
}
[Fact]
public async Task FieldAssignedInCtor_DifferentInstance()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|];
MyClass()
{
var goo = new MyClass();
goo._goo = 0;
}
}
""");
}
[Fact]
public async Task FieldAssignedInCtor_DifferentInstance_ObjectInitializer()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|];
MyClass()
{
var goo = new MyClass { _goo = 0 };
}
}
""");
}
[Fact]
public async Task FieldAssignedInCtor_QualifiedWithThis()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
MyClass()
{
this._goo = 0;
}
}
""",
"""
class MyClass
{
private readonly int _goo;
MyClass()
{
this._goo = 0;
}
}
""");
}
[Fact]
public async Task FieldReturnedInProperty()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
int Goo
{
get { return _goo; }
}
}
""",
"""
class MyClass
{
private readonly int _goo;
int Goo
{
get { return _goo; }
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/29746")]
public async Task FieldReturnedInMethod()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private string [|_s|];
public MyClass(string s) => _s = s;
public string Method()
{
return _s;
}
}
""",
"""
class MyClass
{
private readonly string [|_s|];
public MyClass(string s) => _s = s;
public string Method()
{
return _s;
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/29746")]
public async Task FieldReadInMethod()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private string [|_s|];
public MyClass(string s) => _s = s;
public string Method()
{
return _s.ToUpper();
}
}
""",
"""
class MyClass
{
private readonly string [|_s|];
public MyClass(string s) => _s = s;
public string Method()
{
return _s.ToUpper();
}
}
""");
}
[Fact]
public async Task FieldAssignedInProperty()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|];
int Goo
{
get { return _goo; }
set { _goo = value; }
}
}
""");
}
[Fact]
public async Task FieldAssignedInMethod()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|];
int Goo()
{
_goo = 0;
}
}
""");
}
[Fact]
public async Task FieldAssignedInNestedTypeConstructor()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|];
class Derived : MyClass
{
Derived()
{
_goo = 1;
}
}
}
""");
}
[Fact]
public async Task FieldAssignedInNestedTypeMethod()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|];
class Derived : MyClass
{
void Method()
{
_goo = 1;
}
}
}
""");
}
[Fact]
public async Task FieldInNestedTypeAssignedInConstructor()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
class NestedType
{
private int [|_goo|];
public NestedType()
{
_goo = 0;
}
}
}
""",
"""
class MyClass
{
class NestedType
{
private readonly int _goo;
public NestedType()
{
_goo = 0;
}
}
}
""");
}
[Fact]
public async Task VariableAssignedToFieldInMethod()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
int Goo()
{
var i = _goo;
}
}
""",
"""
class MyClass
{
private readonly int _goo;
int Goo()
{
var i = _goo;
}
}
""");
}
[Fact]
public async Task FieldAssignedInMethodWithCompoundOperator()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|] = 0;
int Goo(int value)
{
_goo += value;
}
}
""");
}
[Fact]
public async Task FieldUsedWithPostfixIncrement()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|] = 0;
int Goo(int value)
{
_goo++;
}
}
""");
}
[Fact]
public async Task FieldUsedWithPrefixDecrement()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|] = 0;
int Goo(int value)
{
--_goo;
}
}
""");
}
[Fact]
public async Task NotAssignedInPartialClass1()
{
await TestInRegularAndScript1Async(
"""
partial class MyClass
{
private int [|_goo|];
}
""",
"""
partial class MyClass
{
private readonly int _goo;
}
""");
}
[Fact]
public async Task NotAssignedInPartialClass2()
{
await TestInRegularAndScript1Async(
"""
partial class MyClass
{
private int [|_goo|];
}
partial class MyClass
{
}
""",
"""
partial class MyClass
{
private readonly int _goo;
}
partial class MyClass
{
}
""");
}
[Fact]
public async Task NotAssignedInPartialClass3()
{
await TestInRegularAndScript1Async(
"""
<Workspace>
<Project Language="C#" AssemblyName="Assembly1" CommonReferences="true">
<Document>partial class MyClass
{
private int [|_goo|];
}
</Document>
<Document>partial class MyClass
{
void M()
{
}
}
</Document>
</Project>
</Workspace>
""",
"""
<Workspace>
<Project Language="C#" AssemblyName="Assembly1" CommonReferences="true">
<Document>partial class MyClass
{
private readonly int _goo;
}
</Document>
<Document>partial class MyClass
{
void M()
{
}
}
</Document>
</Project>
</Workspace>
""");
}
[Fact]
public async Task AssignedInPartialClass1()
{
await TestMissingInRegularAndScriptAsync(
"""
partial class MyClass
{
private int [|_goo|];
void SetGoo()
{
_goo = 0;
}
}
""");
}
[Fact]
public async Task AssignedInPartialClass2()
{
await TestMissingInRegularAndScriptAsync(
"""
partial class MyClass
{
private int [|_goo|];
}
partial class MyClass
{
void SetGoo()
{
_goo = 0;
}
}
""");
}
[Fact]
public async Task AssignedInPartialClass3()
{
await TestMissingInRegularAndScriptAsync(
"""
<Workspace>
<Project Language="C#" AssemblyName="Assembly1" CommonReferences="true">
<Document>partial class MyClass
{
private int [|_goo|];
}
</Document>
<Document>partial class MyClass
{
void SetGoo()
{
_goo = 0;
}
}
</Document>
</Project>
</Workspace>
""");
}
[Fact]
public async Task PassedAsParameter()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
void Goo()
{
Bar(_goo);
}
void Bar(int goo)
{
}
}
""",
"""
class MyClass
{
private readonly int _goo;
void Goo()
{
Bar(_goo);
}
void Bar(int goo)
{
}
}
""");
}
[Fact]
public async Task PassedAsOutParameter()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|];
void Goo()
{
int.TryParse("123", out _goo);
}
}
""");
}
[Fact]
public async Task PassedAsRefParameter()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|];
void Goo()
{
Bar(ref _goo);
}
void Bar(ref int goo)
{
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRef1()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|];
internal ref int Goo()
{
return ref _goo;
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRef2()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|];
internal ref int Goo()
=> ref _goo;
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRef3()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|];
internal struct Accessor
{
private MyClass _instance;
internal ref int Goo => ref _instance._goo;
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRef4()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_a|];
private int _b;
internal ref int Goo(bool first)
{
return ref (first ? ref _a : ref _b);
}
}
""");
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int _a;
private int [|_b|];
internal ref int Goo(bool first)
{
return ref (first ? ref _a : ref _b);
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRef5()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_a|];
private int _b;
internal ref int Goo(bool first)
=> ref (first ? ref _a : ref _b);
}
""");
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int _a;
private int [|_b|];
internal ref int Goo(bool first)
=> ref (first ? ref _a : ref _b);
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRef6()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private int [|_goo|];
internal int Goo()
{
return Local();
ref int Local()
{
return ref _goo;
}
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRef7()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
delegate ref int D();
private int [|_goo|];
internal int Goo()
{
D d = () => ref _goo;
return d();
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRef8()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
delegate ref int D();
private int [|_goo|];
internal int Goo()
{
D d = delegate { return ref _goo; };
return d();
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRefReadonly1()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
internal ref readonly int Goo()
{
return ref _goo;
}
}
""",
"""
class MyClass
{
private readonly int _goo;
internal ref readonly int Goo()
{
return ref _goo;
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRefReadonly2()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
internal ref readonly int Goo()
=> ref _goo;
}
""",
"""
class MyClass
{
private readonly int _goo;
internal ref readonly int Goo()
=> ref _goo;
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRefReadonly3()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
internal struct Accessor
{
private MyClass _instance;
internal ref readonly int Goo => ref _instance._goo;
}
}
""",
"""
class MyClass
{
private readonly int _goo;
internal struct Accessor
{
private MyClass _instance;
internal ref readonly int Goo => ref _instance._goo;
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRefReadonly4()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_a|];
private int _b;
internal ref readonly int Goo(bool first)
{
return ref (first ? ref _a : ref _b);
}
}
""",
"""
class MyClass
{
private readonly int _a;
private int _b;
internal ref readonly int Goo(bool first)
{
return ref (first ? ref _a : ref _b);
}
}
""");
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int _a;
private int [|_b|];
internal ref readonly int Goo(bool first)
{
return ref (first ? ref _a : ref _b);
}
}
""",
"""
class MyClass
{
private int _a;
private readonly int _b;
internal ref readonly int Goo(bool first)
{
return ref (first ? ref _a : ref _b);
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRefReadonly5()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_a|];
private int _b;
internal ref readonly int Goo(bool first)
=> ref (first ? ref _a : ref _b);
}
""",
"""
class MyClass
{
private readonly int _a;
private int _b;
internal ref readonly int Goo(bool first)
=> ref (first ? ref _a : ref _b);
}
""");
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int _a;
private int [|_b|];
internal ref readonly int Goo(bool first)
=> ref (first ? ref _a : ref _b);
}
""",
"""
class MyClass
{
private int _a;
private readonly int _b;
internal ref readonly int Goo(bool first)
=> ref (first ? ref _a : ref _b);
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRefReadonly6()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
internal int Goo()
{
return Local();
ref readonly int Local()
{
return ref _goo;
}
}
}
""",
"""
class MyClass
{
private readonly int _goo;
internal int Goo()
{
return Local();
ref readonly int Local()
{
return ref _goo;
}
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRefReadonly7()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
delegate ref readonly int D();
private int [|_goo|];
internal int Goo()
{
D d = () => ref _goo;
return d();
}
}
""",
"""
class MyClass
{
delegate ref readonly int D();
private readonly int _goo;
internal int Goo()
{
D d = () => ref _goo;
return d();
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ReturnedByRefReadonly8()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
delegate ref readonly int D();
private int [|_goo|];
internal int Goo()
{
D d = delegate { return ref _goo; };
return d();
}
}
""",
"""
class MyClass
{
delegate ref readonly int D();
private readonly int _goo;
internal int Goo()
{
D d = delegate { return ref _goo; };
return d();
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ConditionOfRefConditional1()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private bool [|_a|];
private int _b;
internal ref int Goo()
{
return ref (_a ? ref _b : ref _b);
}
}
""",
"""
class MyClass
{
private readonly bool _a;
private int _b;
internal ref int Goo()
{
return ref (_a ? ref _b : ref _b);
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/33009")]
public async Task ConditionOfRefConditional2()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private bool [|_a|];
private int _b;
internal ref int Goo()
=> ref (_a ? ref _b : ref _b);
}
""",
"""
class MyClass
{
private readonly bool _a;
private int _b;
internal ref int Goo()
=> ref (_a ? ref _b : ref _b);
}
""");
}
[Fact]
public async Task PassedAsOutParameterInCtor()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
MyClass()
{
int.TryParse("123", out _goo);
}
}
""",
"""
class MyClass
{
private readonly int _goo;
MyClass()
{
int.TryParse("123", out _goo);
}
}
""");
}
[Fact]
public async Task PassedAsRefParameterInCtor()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
MyClass()
{
Bar(ref _goo);
}
void Bar(ref int goo)
{
}
}
""",
"""
class MyClass
{
private readonly int _goo;
MyClass()
{
Bar(ref _goo);
}
void Bar(ref int goo)
{
}
}
""");
}
[Fact]
public async Task StaticFieldAssignedInStaticCtor()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private static int [|_goo|];
static MyClass()
{
_goo = 0;
}
}
""",
"""
class MyClass
{
private static readonly int _goo;
static MyClass()
{
_goo = 0;
}
}
""");
}
[Fact]
public async Task StaticFieldAssignedInNonStaticCtor()
{
await TestMissingInRegularAndScriptAsync(
"""
class MyClass
{
private static int [|_goo|];
MyClass()
{
_goo = 0;
}
}
""");
}
[Fact]
public async Task FieldTypeIsMutableStruct()
{
await TestMissingInRegularAndScriptAsync(
"""
struct MyStruct
{
private int _goo;
}
class MyClass
{
private MyStruct [|_goo|];
}
""");
}
[Fact]
public async Task FieldTypeIsCustomImmutableStruct()
{
await TestInRegularAndScript1Async(
"""
struct MyStruct
{
private readonly int _goo;
private const int _bar = 0;
private static int _fizz;
}
class MyClass
{
private MyStruct [|_goo|];
}
""",
"""
struct MyStruct
{
private readonly int _goo;
private const int _bar = 0;
private static int _fizz;
}
class MyClass
{
private readonly MyStruct _goo;
}
""");
}
[Fact]
public async Task FixAll()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int {|FixAllInDocument:_goo|} = 0, _bar = 0;
private int _x = 0, _y = 0, _z = 0;
private int _fizz = 0;
void Method() { _z = 1; }
}
""",
"""
class MyClass
{
private readonly int _goo = 0, _bar = 0;
private readonly int _x = 0;
private readonly int _y = 0;
private int _z = 0;
private readonly int _fizz = 0;
void Method() { _z = 1; }
}
""");
}
[Fact]
public async Task FixAll2()
{
await TestInRegularAndScript1Async(
"""
using System;
partial struct MyClass
{
private static Func<int, bool> {|FixAllInDocument:_test1|} = x => x > 0;
private static Func<int, bool> _test2 = x => x < 0;
private static Func<int, bool> _test3 = x =>
{
return x == 0;
};
private static Func<int, bool> _test4 = x =>
{
return x != 0;
};
}
partial struct MyClass { }
""",
"""
using System;
partial struct MyClass
{
private static readonly Func<int, bool> _test1 = x => x > 0;
private static readonly Func<int, bool> _test2 = x => x < 0;
private static readonly Func<int, bool> _test3 = x =>
{
return x == 0;
};
private static readonly Func<int, bool> _test4 = x =>
{
return x != 0;
};
}
partial struct MyClass { }
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/26262")]
public async Task FieldAssignedInCtor_InParens()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
MyClass()
{
(_goo) = 0;
}
}
""",
"""
class MyClass
{
private readonly int _goo;
MyClass()
{
(_goo) = 0;
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/26262")]
public async Task FieldAssignedInCtor_QualifiedWithThis_InParens()
{
await TestInRegularAndScript1Async(
"""
class MyClass
{
private int [|_goo|];
MyClass()
{
(this._goo) = 0;
}
}
""",
"""
class MyClass
{
private readonly int _goo;
MyClass()
{
(this._goo) = 0;
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/26264")]
public async Task FieldAssignedInMethod_InDeconstruction()
{
await TestMissingAsync(
"""
class C
{
[|int i;|]
int j;
void M()
{
(i, j) = (1, 2);
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/26264")]
public async Task FieldAssignedInMethod_InDeconstruction_InParens()
{
await TestMissingAsync(
"""
class C
{
[|int i;|]
int j;
void M()
{
((i, j), j) = ((1, 2), 3);
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/26264")]
public async Task FieldAssignedInMethod_InDeconstruction_WithThis_InParens()
{
await TestMissingAsync(
"""
class C
{
[|int i;|]
int j;
void M()
{
((this.i, j), j) = (1, 2);
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/26264")]
public async Task FieldUsedInTupleExpressionOnRight()
{
await TestInRegularAndScript1Async(
"""
class C
{
[|int i;|]
int j;
void M()
{
(j, j) = (i, i);
}
}
""",
"""
class C
{
readonly int i;
int j;
void M()
{
(j, j) = (i, i);
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/26264")]
public async Task FieldInTypeWithGeneratedCode()
{
await TestInRegularAndScript1Async(
"""
class C
{
[|private int i;|]
[System.CodeDom.Compiler.GeneratedCodeAttribute("", "")]
private int j;
void M()
{
}
}
""",
"""
class C
{
private readonly int i;
[System.CodeDom.Compiler.GeneratedCodeAttribute("", "")]
private int j;
void M()
{
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/26364")]
public async Task FieldIsFixed()
{
await TestMissingInRegularAndScriptAsync(
"""
unsafe struct S
{
[|private fixed byte b[8];|]
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/38995")]
public async Task FieldAssignedToLocalRef()
{
await TestMissingAsync(
"""
class Program
{
[|int i;|]
void M()
{
ref var value = ref i;
value += 1;
}
}
""");
}
[Fact]
public async Task FieldAssignedToLocalReadOnlyRef()
{
await TestInRegularAndScript1Async(
"""
class Program
{
[|int i;|]
void M()
{
ref readonly var value = ref i;
}
}
""",
"""
class Program
{
[|readonly int i;|]
void M()
{
ref readonly var value = ref i;
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/26213")]
public async Task TestFieldAccessesOnLeftOfDot()
{
await TestInRegularAndScript1Async(
"""
interface IFaceServiceClient
{
void DetectAsync();
}
public class Repro
{
private static IFaceServiceClient [|faceServiceClient|] = null;
public static void Run()
{
faceServiceClient.DetectAsync();
}
}
""",
"""
interface IFaceServiceClient
{
void DetectAsync();
}
public class Repro
{
private static readonly IFaceServiceClient faceServiceClient = null;
public static void Run()
{
faceServiceClient.DetectAsync();
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/42759")]
public async Task TestVolatileField1()
{
await TestInRegularAndScript1Async(
"""
class TestClass
{
private volatile object [|first|];
}
""",
"""
class TestClass
{
private readonly object first;
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/42759")]
public async Task TestVolatileField2()
{
await TestInRegularAndScript1Async(
"""
class TestClass
{
private volatile object [|first|], second;
}
""",
"""
class TestClass
{
private readonly object first;
private volatile object second;
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/42759")]
public async Task TestVolatileField3()
{
await TestInRegularAndScript1Async(
"""
class TestClass
{
private volatile object first, [|second|];
}
""",
"""
class TestClass
{
private volatile object first;
private readonly object second;
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/46785")]
public async Task UsedAsRef_NoDiagnostic()
{
await TestMissingInRegularAndScriptAsync(
"""
public class C
{
private string [|x|] = string.Empty;
public bool M()
{
ref var myVar = ref x;
return myVar is null;
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/57983")]
public async Task UsedAsRef_NoDiagnostic_02()
{
await TestMissingInRegularAndScriptAsync(
"""
using System.Runtime.CompilerServices;
public class Test
{
private ulong [|nextD3D12ComputeFenceValue|];
internal void Repro()
{
ref ulong d3D12FenceValue = ref Unsafe.NullRef<ulong>();
d3D12FenceValue = ref nextD3D12ComputeFenceValue;
d3D12FenceValue++;
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/42760")]
public async Task WithThreadStaticAttribute_NoDiagnostic()
{
await TestMissingInRegularAndScriptAsync(
"""
using System;
class Program
{
[ThreadStatic]
private static object [|t_obj|];
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/50925")]
public async Task Test_MemberUsedInGeneratedCode()
{
await TestMissingInRegularAndScriptAsync(
"""
<Workspace>
<Project Language = "C#" AssemblyName="Assembly1" CommonReferences="true">
<Document FilePath = "z:\\File1.cs">
public sealed partial class Test
{
private int [|_value|];
public static void M()
=> _ = new Test { Value = 1 };
}
</Document>
<Document FilePath = "z:\\File2.g.cs">
using System.CodeDom.Compiler;
[GeneratedCode(null, null)]
public sealed partial class Test
{
public int Value
{
get => _value;
set => _value = value;
}
}
</Document>
</Project>
</Workspace>
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/40644")]
public async Task ShouldNotWarnForDataMemberFieldsInDataContractClasses()
{
await TestMissingAsync(
"""
<Workspace>
<Project Language="C#" AssemblyName="Assembly1" CommonReferencesNet45="true">
<Document>
[System.Runtime.Serialization.DataContractAttribute]
public class MyClass
{
[System.Runtime.Serialization.DataMember]
private bool [|isReadOnly|];
}
</Document>
</Project>
</Workspace>
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/40644")]
public async Task ShouldWarnForDataMemberFieldsInNonDataContractClasses()
{
await TestInRegularAndScript1Async(
"""
<Workspace>
<Project Language="C#" AssemblyName="Assembly1" CommonReferencesNet45="true">
<Document>
public class MyClass
{
[System.Runtime.Serialization.DataMember]
private bool [|isReadOnly|];
}
</Document>
</Project>
</Workspace>
""",
"""
<Workspace>
<Project Language="C#" AssemblyName="Assembly1" CommonReferencesNet45="true">
<Document>
public class MyClass
{
[System.Runtime.Serialization.DataMember]
private readonly bool isReadOnly;
}
</Document>
</Project>
</Workspace>
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/40644")]
public async Task ShouldWarnForPrivateNonDataMemberFieldsInDataContractClasses()
{
await TestInRegularAndScript1Async(
"""
<Workspace>
<Project Language="C#" AssemblyName="Assembly1" CommonReferencesNet45="true">
<Document>
[System.Runtime.Serialization.DataContractAttribute]
public class MyClass
{
[System.Runtime.Serialization.DataMember]
private bool isReadOnly;
private bool [|isReadOnly2|];
}
</Document>
</Project>
</Workspace>
""",
"""
<Workspace>
<Project Language="C#" AssemblyName="Assembly1" CommonReferencesNet45="true">
<Document>
[System.Runtime.Serialization.DataContractAttribute]
public class MyClass
{
[System.Runtime.Serialization.DataMember]
private bool isReadOnly;
private readonly bool isReadOnly2;
}
</Document>
</Project>
</Workspace>
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/40644")]
public async Task ShouldNotWarnForPublicImplicitDataMemberFieldsInDataContractClasses()
{
await TestMissingAsync(
"""
<Workspace>
<Project Language="C#" AssemblyName="Assembly1" CommonReferencesNet45="true">
<Document>
[System.Runtime.Serialization.DataContractAttribute]
public class MyClass
{
public bool [|isReadOnly|];
}
</Document>
</Project>
</Workspace>
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/59577")]
public async Task TestInStruct()
{
await TestInRegularAndScript1Async(
"""
struct MyClass
{
private int [|_goo|];
}
""",
"""
struct MyClass
{
private readonly int _goo;
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/59577")]
public async Task MissingForMemberInStructThatOverwritesThis()
{
await TestMissingAsync(
"""
struct MyClass
{
private int [|_goo|];
void M()
{
this = default;
}
}
""");
}
[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/38468")]
public async Task PreserveLeadingTrivia1()
{
await TestInRegularAndScript1Async(
"""
public class C
{
int x;
int [|y|];
}
""",
"""
public class C
{
int x;
readonly int y;
}
""");
}
[Fact, WorkItem(47197, "https://github.com/dotnet/roslyn/issues/47197")]
public async Task StrictFeatureFlagAssignment1()
{
await TestInRegularAndScriptAsync(
"""
using System;
using System.Collections.Generic;
class C<T>
{
private static IEqualityComparer<T> [|s_value|];
static C()
{
C<T>.s_value = null;
}
}
""",
"""
using System;
using System.Collections.Generic;
class C<T>
{
private static readonly IEqualityComparer<T> s_value;
static C()
{
C<T>.s_value = null;
}
}
""", parseOptions: s_strictFeatureFlag);
}
[Fact, WorkItem(47197, "https://github.com/dotnet/roslyn/issues/47197")]
public async Task StrictFeatureFlagAssignment2()
{
await TestMissingInRegularAndScriptAsync(
"""
using System;
using System.Collections.Generic;
class C<T>
{
private static IEqualityComparer<T> [|s_value|];
static C()
{
C<string>.s_value = null;
}
}
""", new TestParameters(parseOptions: s_strictFeatureFlag));
}
[Fact, WorkItem(47197, "https://github.com/dotnet/roslyn/issues/47197")]
public async Task StrictFeatureFlagAssignment3()
{
await TestMissingInRegularAndScriptAsync(
"""
using System;
using System.Collections.Generic;
class C<T>
{
private static IEqualityComparer<T> [|s_value|];
static C()
{
C<string>.s_value = null;
}
}
""");
}
}
|