AddBracesTests.cs

// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
 
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.CodeFixes;
using Microsoft.CodeAnalysis.CodeStyle;
using Microsoft.CodeAnalysis.CSharp.CodeStyle;
using Microsoft.CodeAnalysis.CSharp.Diagnostics.AddBraces;
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Diagnostics;
using Microsoft.CodeAnalysis.Test.Utilities;
using Roslyn.Test.Utilities;
using Xunit;
using Xunit.Abstractions;
 
namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.AddBraces;
 
[Trait(Traits.Feature, Traits.Features.CodeActionsAddBraces)]
public partial class AddBracesTests : AbstractCSharpDiagnosticProviderBasedUserDiagnosticTest_NoEditor
{
    public AddBracesTests(ITestOutputHelper logger)
       : base(logger)
    {
    }
 
    internal override (DiagnosticAnalyzer, CodeFixProvider) CreateDiagnosticProviderAndFixer(Workspace workspace)
        => (new CSharpAddBracesDiagnosticAnalyzer(), new CSharpAddBracesCodeFixProvider());
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    public async Task DoNotFireForIfWithBraces(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|if|] (true)
                    {
                        return;
                    }
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    public async Task DoNotFireForElseWithBraces(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        return;
                    }
                    [|else|]
                    {
                        return;
                    }
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    public async Task DoNotFireForElseWithChildIf(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                        return;
                    [|else|] if (false)
                        return;
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    public async Task DoNotFireForForWithBraces(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|for|] (var i = 0; i < 5; i++)
                    {
                        return;
                    }
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    public async Task DoNotFireForForEachWithBraces(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|foreach|] (var c in "test")
                    {
                        return;
                    }
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    public async Task DoNotFireForWhileWithBraces(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|while|] (true)
                    {
                        return;
                    }
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    public async Task DoNotFireForDoWhileWithBraces(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|do|]
                    {
                        return;
                    }
                    while (true);
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    public async Task DoNotFireForUsingWithBraces(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|using|] (var f = new Fizz())
                    {
                        return;
                    }
                }
            }
 
            class Fizz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    public async Task DoNotFireForUsingWithChildUsing(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|using|] (var f = new Fizz())
                    using (var b = new Buzz())
                        return;
                }
            }
 
            class Fizz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
 
            class Buzz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    public async Task DoNotFireForLockWithBraces(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            class Program
            {
                static void Main()
                {
                    var str = "test";
                    [|lock|] (str)
                    {
                        return;
                    }
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    public async Task DoNotFireForLockWithChildLock(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            class Program
            {
                static void Main()
                {
                    var str1 = "test";
                    var str2 = "test";
                    [|lock|] (str1)
                        lock (str2)
                            return;
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    public async Task DoNotFireForFixedWithChildFixed(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            class Program
            {
                unsafe static void Main()
                {
                    [|fixed|] (int* p = null)
                    fixed (int* q = null)
                    {
                    }
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForFixedWithoutBraces(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                unsafe static void Main()
                {
                    fixed (int* p = null)
                    [|fixed|] (int* q = null)
                        return;
                }
            }
            """,
            """
            class Program
            {
                unsafe static void Main()
                {
                    fixed (int* p = null)
                    fixed (int* q = null)
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForIfWithoutBraces(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|if|] (true) return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory, WorkItem("https://github.com/dotnet/roslyn/issues/57770")]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForIfWithoutBracesTopLevel(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            [|if|] (true) return;
            """,
            """
            if (true)
            {
                return;
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, true)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForElseWithoutBracesButHasContextBraces(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    if (true) { return; }
                    [|else|] return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    if (true) { return; }
                    else
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForElseWithoutBraces(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    if (true) return;
                    [|else|] return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    if (true) return;
                    else
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForStandaloneElseWithoutBraces(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|else|]
                        return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    else
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForIfNestedInElseWithoutBraces(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    if (true) return;
                    else [|if|] (false) return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    if (true) return;
                    else if (false)
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForIfNestedInElseWithoutBracesWithMultilineContext1(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                        if (true)   // This multiline statement does not directly impact the other nested statement
                            return;
                        else
                            return;
                    else [|if|] (false) return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                        if (true)   // This multiline statement does not directly impact the other nested statement
                            return;
                        else
                            return;
                    else if (false)
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, true)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForIfNestedInElseWithoutBracesWithMultilineContext2(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        if (true)
                            return;
                        else
                            return;
                    }
                    else [|if|] (false) return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        if (true)
                            return;
                        else
                            return;
                    }
                    else if (false)
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForIfNestedInElseWithoutBracesWithMultilineContext3(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        [|if|] (true)
                            return;
                        else
                            return;
                    }
                    else if (false) return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        if (true)
                        {
                            return;
                        }
                        else
                            return;
                    }
                    else if (false) return;
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForIfNestedInElseWithoutBracesWithMultilineContext4(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        if (true)
                            return;
                        [|else|]
                            return;
                    }
                    else if (false) return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        if (true)
                            return;
                        else
                        {
                            return;
                        }
                    }
                    else if (false) return;
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
#pragma warning disable CA1200 // Avoid using cref tags with a prefix - Remove the suppression when https://github.com/dotnet/roslyn/issues/42611 is fixed.
    /// <summary>
    /// Verifies that the use of braces in a construct nested within the true portion of an <c>if</c> statement does
    /// not trigger the multiline behavior the <c>else</c> clause of a containing stetemnet for
    /// <see cref="F:Microsoft.CodeAnalysis.CodeStyle.PreferBracesPreference.WhenMultiline"/>. The <c>else</c> clause would only need braces if the true
    /// portion also used braces (which would be required if the true portion was considered multiline.
    /// </summary>
#pragma warning restore CA1200 // Avoid using cref tags with a prefix
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForIfNestedInElseWithoutBracesWithMultilineContext5(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        if (true)
                            if (true) { return; } else { return; }
                        [|else|]
                            return;
                    }
                    else if (false) return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        if (true)
                            if (true) { return; } else { return; }
                        else
                        {
                            return;
                        }
                    }
                    else if (false) return;
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForForWithoutBraces(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|for|] (var i = 0; i < 5; i++) return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    for (var i = 0; i < 5; i++)
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, true)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForMultilineForWithoutBraces1(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|for|] (var i = 0;
                        i < 5;
                        i++) return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    for (var i = 0;
                        i < 5;
                        i++)
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, true)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForMultilineForWithoutBraces2(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|for|] (var i = 0; i < 5; i++) if (true)
                        return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    for (var i = 0; i < 5; i++)
                    {
                        if (true)
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, true)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForMultilineForWithoutBraces3(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|for|] (var i = 0; i < 5; i++)
                        if (true)
                            return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    for (var i = 0; i < 5; i++)
                    {
                        if (true)
                            return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForForEachWithoutBraces(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|foreach|] (var c in "test") return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    foreach (var c in "test")
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForWhileWithoutBraces(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|while|] (true) return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    while (true)
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForDoWhileWithoutBraces1(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|do|] return; while (true);
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    do
                    {
                        return;
                    }
                    while (true);
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForDoWhileWithoutBraces2(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|do|]
                        return;
                    while (true);
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    do
                    {
                        return;
                    }
                    while (true);
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, true)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForMultilineDoWhileWithoutBraces1(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|do|] return; while (true ||
                        true);
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    do
                    {
                        return;
                    }
                    while (true ||
                        true);
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForUsingWithoutBraces(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    [|using|] (var f = new Fizz())
                        return;
                }
            }
 
            class Fizz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    using (var f = new Fizz())
                    {
                        return;
                    }
                }
            }
 
            class Fizz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForUsingWithoutBracesNestedInUsing(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    using (var f = new Fizz())
                    [|using|] (var b = new Buzz())
                        return;
                }
            }
 
            class Fizz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
 
            class Buzz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    using (var f = new Fizz())
                    using (var b = new Buzz())
                    {
                        return;
                    }
                }
            }
 
            class Fizz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
 
            class Buzz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForMultilineUsingWithoutBracesNestedInUsing1(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    using (var f        // <-- This multiline condition doesn't trigger a multiline braces requirement when it's the outer 'using' statement
                        = new Fizz())
                    [|using|] (var b = new Buzz())
                        return;
                }
            }
 
            class Fizz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
 
            class Buzz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    using (var f        // <-- This multiline condition doesn't trigger a multiline braces requirement when it's the outer 'using' statement
                        = new Fizz())
                    using (var b = new Buzz())
                    {
                        return;
                    }
                }
            }
 
            class Fizz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
 
            class Buzz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, true)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForMultilineUsingWithoutBracesNestedInUsing2(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    using (var f = new Fizz())
                    [|using|] (var b        // <-- This multiline condition triggers a multiline braces requirement because it's the inner 'using' statement
                        = new Buzz())
                        return;
                }
            }
 
            class Fizz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
 
            class Buzz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    using (var f = new Fizz())
                    using (var b        // <-- This multiline condition triggers a multiline braces requirement because it's the inner 'using' statement
                        = new Buzz())
                    {
                        return;
                    }
                }
            }
 
            class Fizz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
 
            class Buzz : IDisposable
            {
                public void Dispose()
                {
                    throw new NotImplementedException();
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForLockWithoutBraces(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    var str = "test";
                    [|lock|] (str)
                        return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    var str = "test";
                    lock (str)
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    public async Task FireForLockWithoutBracesNestedInLock(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            class Program
            {
                static void Main()
                {
                    var str1 = "test";
                    var str2 = "test";
 
                    lock (str1)
                    [|lock|] (str2) // VS thinks this should be indented one more level
                        return;
                }
            }
            """,
 
            """
            class Program
            {
                static void Main()
                {
                    var str1 = "test";
                    var str2 = "test";
 
                    lock (str1)
                    lock (str2) // VS thinks this should be indented one more level
                        {
                            return;
                        }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task DoNotFireForIfWhenIntercedingDirectiveBefore(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
            #if test
                    [|if (true)|]
            #endif
                        return;
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task DoNotFireForIfWithIntercedingDirectiveAfter(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
                    [|if (true)|]
            #if test
                        return;
            #endif
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None)]
    [InlineData((int)PreferBracesPreference.WhenMultiline)]
    [InlineData((int)PreferBracesPreference.Always)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task DoNotFireForIfElseWithIntercedingDirectiveInBoth(int bracesPreference)
    {
        await TestMissingInRegularAndScriptAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
                    [|if (true)
            #if test
                        return;
                    else|]
            #endif
                        return;
                }
            }
            """,
            new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, (PreferBracesPreference)bracesPreference, NotificationOption2.Silent)));
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task OnlyFireForIfWithIntercedingDirectiveInElseAroundIf(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
            #if test
                    [|if (true)
                        return;
                    else|]
            #endif
                        return;
                }
            }
            """,
 
            """
            #define test
            class Program
            {
                static void Main()
                {
            #if test
                    if (true)
                    {
                        return;
                    }
                    else
            #endif
                        return;
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task OnlyFireForElseWithIntercedingDirectiveInIfAroundElse(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
                    [|if (true)
            #if test
                        return;
                    else|]
                        return;
            #endif
                }
            }
            """,
 
            """
            #define test
            class Program
            {
                static void Main()
                {
                    if (true)
            #if test
                        return;
                    else
                    {
                        return;
                    }
            #endif
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task OnlyFireForElseWithIntercedingDirectiveInIf(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
            #if test
                    [|if (true)
            #endif
                        return;
                    else|]
                        return;
                }
            }
            """,
 
            """
            #define test
            class Program
            {
                static void Main()
                {
            #if test
                    if (true)
            #endif
                        return;
                    else
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task OnlyFireForIfWithIntercedingDirectiveInElse(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
                    [|if (true)
                        return;
                    else|]
            #if test
                        return;
            #endif
                }
            }
            """,
 
            """
            #define test
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        return;
                    }
                    else
            #if test
                        return;
            #endif
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, true)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task FireForIfElseWithDirectiveAroundIf(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
            #if test
                    [|if (true)
                        return;
            #endif
                    else|]
                    {
                        return;
                    }
                }
            }
            """,
 
            """
            #define test
            class Program
            {
                static void Main()
                {
            #if test
                    if (true)
                    {
                        return;
                    }
            #endif
                    else
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, true)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task FireForIfElseWithDirectiveAroundElse(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
                    [|if (true)
                    {
                        return;
                    }
            #if test
                    else|]
                        return;
            #endif
                }
            }
            """,
 
            """
            #define test
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        return;
                    }
            #if test
                    else
                    {
                        return;
                    }
            #endif
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task FireForIfWithoutIntercedingDirective(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
            #if test
            #endif
                    [|if (true)|]
                        return;
                }
            }
            """,
 
            """
            #define test
            class Program
            {
                static void Main()
                {
            #if test
            #endif
                    if (true)
                    {
                        return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task FireForIfWithDirectiveAfterEmbeddedStatement(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
                    [|if (true)|]
                        return;
            #if test
            #endif
                }
            }
            """,
 
            """
            #define test
            class Program
            {
                static void Main()
                {
                    if (true)
                    {
                        return;
                    }
            #if test
            #endif
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task FireForInnerNestedStatementWhenDirectiveEntirelyInside(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
                    [|while (true)
            #if test
                        if (true)|]
                            return;
            #endif
                }
            }
            """,
 
            """
            #define test
            class Program
            {
                static void Main()
                {
                    while (true)
            #if test
                        if (true)
                        {
                            return;
                        }
            #endif
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    [Theory]
    [InlineData((int)PreferBracesPreference.None, false)]
    [InlineData((int)PreferBracesPreference.WhenMultiline, true)]
    [InlineData((int)PreferBracesPreference.Always, true)]
    [WorkItem("https://github.com/dotnet/roslyn/issues/32480")]
    public async Task FireForOuterNestedStatementWhenDirectiveEntirelyInside(int bracesPreference, bool expectDiagnostic)
    {
        await TestAsync(
            """
            #define test
            class Program
            {
                static void Main()
                {
                    [|while (true)
            #if test
                        if (true)|]
            #endif
                            return;
                }
            }
            """,
 
            """
            #define test
            class Program
            {
                static void Main()
                {
                    while (true)
                    {
            #if test
                        if (true)
            #endif
                            return;
                    }
                }
            }
            """,
            (PreferBracesPreference)bracesPreference,
            expectDiagnostic);
    }
 
    private async Task TestAsync(string initialMarkup, string expectedMarkup, PreferBracesPreference bracesPreference, bool expectDiagnostic)
    {
        if (expectDiagnostic)
        {
            await TestInRegularAndScriptAsync(initialMarkup, expectedMarkup, options: Option(CSharpCodeStyleOptions.PreferBraces, bracesPreference, NotificationOption2.Silent));
        }
        else
        {
            await TestMissingInRegularAndScriptAsync(initialMarkup, new TestParameters(options: Option(CSharpCodeStyleOptions.PreferBraces, bracesPreference, NotificationOption2.Silent)));
        }
    }
}
File: src\Analyzers\CSharp\Tests\AddBraces\AddBracesTests.cs	Web Access
Project: src\src\CodeStyle\CSharp\Tests\Microsoft.CodeAnalysis.CSharp.CodeStyle.UnitTests.csproj (Microsoft.CodeAnalysis.CSharp.CodeStyle.UnitTests)